[webkit-reviews] review denied: [Bug 176076] Do unified source builds for JSC : [Attachment 320569] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 176076: Do unified source builds for JSC
https://bugs.webkit.org/show_bug.cgi?id=176076

Attachment 320569: Patch

https://bugs.webkit.org/attachment.cgi?id=320569&action=review




--- Comment #31 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320569
  --> https://bugs.webkit.org/attachment.cgi?id=320569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320569&action=review

I think a good way to land this would be to land all the parts that make
changes that make no effect, then land the rest.

> Source/JavaScriptCore/CMakeLists.txt:49
> -set(JavaScriptCore_SOURCES
> +set(JavaScriptCore_OG_SOURCES

What does OG mean?  I don't think we should use such an abbreviation.

> Source/JavaScriptCore/CMakeLists.txt:1021
> +    if (NOT (${_sourceFile} MATCHES "c$"))

Do we want to check if it ends with .c or just if it ends with c?

> Source/JavaScriptCore/CMakeLists.txt:1039
> +# These are special files that we can't or don't want to unified source
compile

Why not?  Should we fix this?