[webkit-reviews] review granted: [Bug 176728] Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal : [Attachment 320526] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 12 09:29:07 PDT 2017


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176728: Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
https://bugs.webkit.org/show_bug.cgi?id=176728

Attachment 320526: Patch

https://bugs.webkit.org/attachment.cgi?id=320526&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 320526
  --> https://bugs.webkit.org/attachment.cgi?id=320526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320526&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:157
> +- (void)_webViewRunModal:(WKWebView *)webView
WK_API_AVAILABLE(macosx(WK_MAC_TBA));

As mentioned on IRC, I think we can do better with this name.


More information about the webkit-reviews mailing list