[webkit-reviews] review granted: [Bug 176767] REGRESSION (r221272): WKWebView gets stuck zoomed in if the web process crashes : [Attachment 320521] Patch

Mon Sep 11 23:03:28 PDT 2017

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 176767: REGRESSION (r221272): WKWebView gets stuck zoomed in if the web
process crashes
https://bugs.webkit.org/show_bug.cgi?id=176767

Attachment 320521: Patch

https://bugs.webkit.org/attachment.cgi?id=320521&action=review

--- Comment #2 from mitz at webkit.org ---
Comment on attachment 320521
  --> https://bugs.webkit.org/attachment.cgi?id=320521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320521&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:228
> +    [webView loadHTMLString:@"<head><meta name='viewport'
content='initial-scale=1' /></head>" baseURL:nil];

No need for the / and the preceding space in the meta tag.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:231
> +    RetainPtr<UIWindow> window = adoptNS([[UIWindow alloc]
initWithFrame:CGRectMake(0, 0, 800, 600)]);

auto?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:236
> +    [webView loadHTMLString:@"<head><meta name='viewport'
content='initial-scale=1' /></head>" baseURL:nil];

“ /”