[webkit-reviews] review granted: [Bug 176721] [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS : [Attachment 320517] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 176721: [iOS DnD] Support DataTransfer.setDragImage when starting a drag on
iOS
https://bugs.webkit.org/show_bug.cgi?id=176721

Attachment 320517: Patch

https://bugs.webkit.org/attachment.cgi?id=320517&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 320517
  --> https://bugs.webkit.org/attachment.cgi?id=320517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320517&action=review

> Source/WebCore/page/DragController.cpp:1248
> +		   if (auto* page = frame.page())
> +		       dragPreviewSize.scale(1 / page->deviceScaleFactor());

This seems a little odd. Did you test with page scale too?

> Source/WebCore/page/DragController.cpp:1252
> +	       // We can simply position the preview simply using the bounds of
the drag source element.

Too many simplys