[webkit-reviews] review granted: [Bug 176441] Web Inspector: make Canvas recording tests more human readable : [Attachment 320403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 11 19:49:48 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 176441: Web Inspector: make Canvas recording tests more human readable
https://bugs.webkit.org/show_bug.cgi?id=176441

Attachment 320403: Patch

https://bugs.webkit.org/attachment.cgi?id=320403&action=review




--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 320403
  --> https://bugs.webkit.org/attachment.cgi?id=320403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320403&action=review

Awesome! r=me

> LayoutTests/inspector/canvas/resources/recording-utilities.js:71
> +			       if (action.parameters[i] !=
action._payloadParameters[i] && Number.isInteger(action._payloadParameters[i]))

Style: Can we use `!==` here?


More information about the webkit-reviews mailing list