[webkit-reviews] review denied: [Bug 176639] QualifiedName::init should assume AtomicStrings::init was already called : [Attachment 320489] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 11 17:08:29 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has denied  review:
Bug 176639: QualifiedName::init should assume AtomicStrings::init was already
called
https://bugs.webkit.org/show_bug.cgi?id=176639

Attachment 320489: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=320489&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 320489
  --> https://bugs.webkit.org/attachment.cgi?id=320489
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320489&action=review

> Source/WTF/wtf/NeverDestroyed.h:114
> +    bool isConstructed() const { return m_isConstructed; }

Needs !ASSERT_DISABLED like the member.


More information about the webkit-reviews mailing list