[webkit-reviews] review granted: [Bug 176731] Web Inspector: Cleanup and test MIMETypeUtilities : [Attachment 320472] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 176731: Web Inspector: Cleanup and test MIMETypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=176731

Attachment 320472: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=320472&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 320472
  --> https://bugs.webkit.org/attachment.cgi?id=320472
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320472&action=review

r=me

> LayoutTests/inspector/unit-tests/mimetype-utilities.html:24
> +	      
InspectorTest.expectEqual(WI.fileExtensionForURL("https://example.com/script.mi
n.js"), "js", `File extension for "script.min.js" should be "js".`);

Should there also be a test for filenames with a trailing period? I know it's
odd but AFAIK it is allowed (on UNIX and Windows at least).

Also, WI.fileExtensionForURL("https://example.com/foo.") returns "" instead of
null. This should probably return null for consistency