[webkit-reviews] review granted: [Bug 176736] [iOS WK2] ExternalSourceDataTransferItemGetAsEntry tests produce inconsistent results on test automation bots : [Attachment 320479] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 176736: [iOS WK2] ExternalSourceDataTransferItemGetAsEntry tests produce
inconsistent results on test automation bots
https://bugs.webkit.org/show_bug.cgi?id=176736

Attachment 320479: Patch

https://bugs.webkit.org/attachment.cgi?id=320479&action=review




--- Comment #2 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 320479
  --> https://bugs.webkit.org/attachment.cgi?id=320479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320479&action=review

Good fix, just make sure that what you're testing against is also guaranteed to
be in alphabetical order. then r=me. Not sure if you need a WK2 review as well.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:966
>      ];

I don't see that this list is sorted again in code. Can you either do that
and/or make a comment that these are expected to be in alphabetical order?