[webkit-reviews] review granted: [Bug 176621] Switch MediaPlayerPrivateAVFoundation to release logging : [Attachment 320430] Patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 176621: Switch MediaPlayerPrivateAVFoundation to release logging
https://bugs.webkit.org/show_bug.cgi?id=176621

Attachment 320430: Patch.

https://bugs.webkit.org/attachment.cgi?id=320430&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 320430
  --> https://bugs.webkit.org/attachment.cgi?id=320430
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=320430&action=review

r=me, with nit.

> Source/WebCore/html/HTMLMediaElement.h:904
> +    const PAL::Logger* mediaPlayerLogger() final { return &logger(); }

Can we just make this a ref rather than a pointer?

> Source/WebCore/platform/graphics/MediaPlayer.h:306
> +    virtual const PAL::Logger* mediaPlayerLogger() { return nullptr; }

You would just make this a pure virtual. (But that's ok; the HTMLMediaElement
is the only MediaPlayerClient, currently.)