[webkit-reviews] review granted: [Bug 176722] Make jsc dump the command line if JSC_dumpOption environment variable is set with a non-zero value. : [Attachment 320457] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 176722: Make jsc dump the command line if JSC_dumpOption environment
variable is set with a non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=176722

Attachment 320457: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=320457&action=review




--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 320457
  --> https://bugs.webkit.org/attachment.cgi?id=320457
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=320457&action=review

> Source/JavaScriptCore/jsc.cpp:3846
> +    if (dumpOptionsOption && strcmp(dumpOptionsOption, "0")) {

OptionsOptionOptionsOptionsOptionOptions

Code seems to usually do:
!strcasecmp(string, "none") || !strcasecmp(string, "no") || !strcasecmp(string,
"false") || !strcmp(string, "0")

?