[webkit-reviews] review granted: [Bug 176680] webkitbot should recognize commands even when colon is omitted : [Attachment 320414] Fixe the bug

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 176680: webkitbot should recognize commands even when colon is omitted
https://bugs.webkit.org/show_bug.cgi?id=176680

Attachment 320414: Fixe the bug

https://bugs.webkit.org/attachment.cgi?id=320414&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 320414
  --> https://bugs.webkit.org/attachment.cgi?id=320414
Fixe the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=320414&action=review

> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
>	       request = request.split(':', 1)
>	   elif vocative_separator == ',':
>	       request = request.split(',', 1)
> +	   elif vocative_separator == ' ':
> +	       request = request.split(' ', 1)

We could simplify this code by using an array and the "in" operator