[webkit-reviews] review granted: [Bug 176581] WSL should support while loops : [Attachment 320409] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 176581: WSL should support while loops
https://bugs.webkit.org/show_bug.cgi?id=176581

Attachment 320409: Patch

https://bugs.webkit.org/attachment.cgi?id=320409&action=review




--- Comment #8 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 320409
  --> https://bugs.webkit.org/attachment.cgi?id=320409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320409&action=review

Nice!  R=me.

> Tools/WebGPUShadingLanguageRI/Break.js:38
> +	   return "Break";

Lowercase is better since that’s what te language does.

> Tools/WebGPUShadingLanguageRI/Checker.js:245
> +	       throw new Error("Trying to negate something with no type: " +
node.conditional);

I don’t think negation is what is going on here.