[webkit-reviews] review granted: [Bug 176642] Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest : [Attachment 320358] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176642: Add WKUIDelegatePrivate equivalent of WKPageUIClient's
decidePolicyForGeolocationPermissionRequest
https://bugs.webkit.org/show_bug.cgi?id=176642

Attachment 320358: Patch

https://bugs.webkit.org/attachment.cgi?id=320358&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 320358
  --> https://bugs.webkit.org/attachment.cgi?id=320358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320358&action=review

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:337
> +Function<void(bool)>
UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest(WebKit::WebPa
geProxy&, WebKit::WebFrameProxy& frame, API::SecurityOrigin& securityOrigin,
Function<void(bool)>&& completionHandler)

As I mentioned in the other patch, I see no reason for the return value. We
pass in a reference to a completion handler, and we null it out / move it out
if we call it, so no need to also move it into a return value.