[webkit-reviews] review granted: [Bug 176010] [DFG] Optimize WeakMap::get by adding intrinsic and fixup : [Attachment 319839] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 176010: [DFG] Optimize WeakMap::get by adding intrinsic and fixup
https://bugs.webkit.org/show_bug.cgi?id=176010

Attachment 319839: Patch

https://bugs.webkit.org/attachment.cgi?id=319839&action=review




--- Comment #17 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 319839
  --> https://bugs.webkit.org/attachment.cgi?id=319839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319839&action=review

R=me other than the AI issue.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1077
> +	   forNode(node).makeBytecodeTop();

Why bytecode top?

Isn’t this heap top?

(It cannot return empty)