[webkit-reviews] review requested: [Bug 139438] [CMake] Enable pre-compiled headers (PCH) : [Attachment 320349] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 139438: [CMake] Enable pre-compiled headers (PCH)
https://bugs.webkit.org/show_bug.cgi?id=139438

Attachment 320349: Patch

https://bugs.webkit.org/attachment.cgi?id=320349&action=review




--- Comment #27 from Adrian Perez <aperez at igalia.com> ---
Created attachment 320349

  --> https://bugs.webkit.org/attachment.cgi?id=320349&action=review

Patch

Updated version. Now this picks all the relevant
build flags which affect generation of the PCHs. After much back and forth
reading the CMake documentation, and checking what Cotire does (it turns
out it does many things because it *does* need to do them) I came up with
a not-so-big as Cotire yet not-as-simple as the solution pointed out by
Konstantin (which didn not work becayse it was missing flags).

Still pending to do actual full builds, with this I am getting consistently
between 1 and 2 minutes of saved build time when building only JSC. Also
gotta add the ChageLog entries and all -- but again, sharing early for
feedback. If somebody could run with this patch on MSVC to make sure I
did not break anything, that would be swell.