[webkit-reviews] review granted: [Bug 176646] [GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline : [Attachment 320340] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 176646: [GStreamer] Missing GRefPtr adoptions in
MediaPlayerPrivateGStreamerBase, PlaybackPipeline
https://bugs.webkit.org/show_bug.cgi?id=176646

Attachment 320340: Patch

https://bugs.webkit.org/attachment.cgi?id=320340&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 320340
  --> https://bugs.webkit.org/attachment.cgi?id=320340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320340&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:464
> +    GRefPtr<GstPad> srcPad = adoptGRef(sinkPad ?
gst_pad_get_peer(sinkPad.get()) : nullptr);

adoptGref(nullptr) looks weird, I would write this as:

GRefPtr<GstPad> srcPad = sinkPad ? adoptGRef(gst_pad_get_peer(sinkPad.get())) :
nullptr;