[webkit-reviews] review granted: [Bug 176645] Error should compute .stack and friends lazily : [Attachment 320335] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 176645: Error should compute .stack and friends lazily
https://bugs.webkit.org/show_bug.cgi?id=176645

Attachment 320335: the patch

https://bugs.webkit.org/attachment.cgi?id=320335&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 320335
  --> https://bugs.webkit.org/attachment.cgi?id=320335
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320335&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   This is an enormous speed-up for programs that allocate and throw
exceptions.

Awesome

> Source/JavaScriptCore/runtime/Error.cpp:41
> +#include "SuperSampler.h"

Please remove it doesn’t look like it’s used

> Source/JavaScriptCore/runtime/ErrorInstance.cpp:29
> +#include "SuperSampler.h"

Please remove it doesn’t look like it’s used