[webkit-reviews] review granted: [Bug 175709] bisect-builds doesn't work due to missing requests module : [Attachment 320301] v2 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 8 15:22:56 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 175709: bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709

Attachment 320301: v2 patch

https://bugs.webkit.org/attachment.cgi?id=320301&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 320301
  --> https://bugs.webkit.org/attachment.cgi?id=320301
v2 patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320301&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:114
> +				"requests-2.18.4/requests")

Wrong indentation. Should be indented by 4 spaces to the right of
self._install.


More information about the webkit-reviews mailing list