[webkit-reviews] review granted: [Bug 176590] [DFG][FTL] GetByVal(ObjectUse with Array::Generic, StringUse/SymbolUse) should be supported : [Attachment 320263] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 176590: [DFG][FTL] GetByVal(ObjectUse with Array::Generic,
StringUse/SymbolUse) should be supported
https://bugs.webkit.org/show_bug.cgi?id=176590

Attachment 320263: Patch

https://bugs.webkit.org/attachment.cgi?id=320263&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 320263
  --> https://bugs.webkit.org/attachment.cgi?id=320263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320263&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3175
> +    JSValueRegs resultRegs = result.regs();

Is it worth using the FlushedCallResult (I forget actual class name) here?