[webkit-reviews] review granted: [Bug 176544] [GStreamer] initializationDataEncountered() dispatch can outlive MediaPlayerPrivateGStreamerBase : [Attachment 320138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 8 01:55:46 PDT 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 176544: [GStreamer] initializationDataEncountered() dispatch can outlive
MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=176544

Attachment 320138: Patch

https://bugs.webkit.org/attachment.cgi?id=320138&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 320138
  --> https://bugs.webkit.org/attachment.cgi?id=320138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320138&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
-367
> -	   String sessionId(createCanonicalUUIDString());

If we're not using createCanonicalUUIDString() anymore, we can probably remove
the UUID header.


More information about the webkit-reviews mailing list