[webkit-reviews] review granted: [Bug 176294] Add "if" statements to WSL : [Attachment 320210] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 176294: Add "if" statements to WSL
https://bugs.webkit.org/show_bug.cgi?id=176294

Attachment 320210: Patch

https://bugs.webkit.org/attachment.cgi?id=320210&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 320210
  --> https://bugs.webkit.org/attachment.cgi?id=320210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320210&action=review

R=me but I wouldn’t remove the type checks.

> Tools/WebGPUShadingLanguageRI/Checker.js:222
> +	   // make sure that the operand is a bool.

I would still check though.