[webkit-reviews] review granted: [Bug 176437] Modernize BoxExtent into RectEdge : [Attachment 320203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 7 17:23:22 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176437: Modernize BoxExtent into RectEdge
https://bugs.webkit.org/show_bug.cgi?id=176437

Attachment 320203: Patch

https://bugs.webkit.org/attachment.cgi?id=320203&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 320203
  --> https://bugs.webkit.org/attachment.cgi?id=320203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320203&action=review

> Source/WebCore/platform/RectEdges.h:79
> +    std::array<T, 4> m_sides {{0, 0, 0, 0}};

Any reason not to use Vector?


More information about the webkit-reviews mailing list