[webkit-reviews] review granted: [Bug 176561] [PAL] Unify PlatformUserPreferredLanguages.h with Language.h : [Attachment 320184] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 176561: [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
https://bugs.webkit.org/show_bug.cgi?id=176561

Attachment 320184: Patch

https://bugs.webkit.org/attachment.cgi?id=320184&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 320184
  --> https://bugs.webkit.org/attachment.cgi?id=320184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320184&action=review

This change looks good, but I think you need to update some GTK-specific files:

platform/text/enchant/TextCheckerEnchant.cpp:25:22: fatal error: Language.h: No
such file or directory

r=me, but no cq+ because there are some missing include corrections.

> Source/WTF/wtf/CMakeLists.txt:233
> +    Language.cpp

Ha! You caught this. :-)