[webkit-reviews] review granted: [Bug 176562] Clean up Geolocation request handling : [Attachment 320181] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176562: Clean up Geolocation request handling
https://bugs.webkit.org/show_bug.cgi?id=176562

Attachment 320181: Patch

https://bugs.webkit.org/attachment.cgi?id=320181&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 320181
  --> https://bugs.webkit.org/attachment.cgi?id=320181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320181&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:5827
> +    completionHandler =
m_uiClient->decidePolicyForGeolocationPermissionRequest(*this, *frame,
origin.get(), WTFMove(completionHandler));
> +#if PLATFORM(IOS)
> +    if (completionHandler)
> +	   completionHandler =
m_pageClient.decidePolicyForGeolocationPermissionRequest(*frame, origin.get(),
WTFMove(completionHandler));
> +#endif
> +    if (completionHandler)
> +	   completionHandler(false);

This looks SO weird, but you explained it. Maybe a comment?