[webkit-reviews] review granted: [Bug 176557] [WK2] Add C API to retrieve the originating page of a WKDownload : [Attachment 320177] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 176557: [WK2] Add C API to retrieve the originating page of a WKDownload
https://bugs.webkit.org/show_bug.cgi?id=176557

Attachment 320177: Patch

https://bugs.webkit.org/attachment.cgi?id=320177&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320177
  --> https://bugs.webkit.org/attachment.cgi?id=320177
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320177&action=review

> Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:102
> +    m_originatingPage = page ? page->createWeakPtr() :
WeakPtr<WebPageProxy>();

will nullptr not work?

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:265
> +void PageClientImpl::handleDownloadRequest(DownloadProxy*)
>  {
> -    ASSERT_ARG(download, download);
> -    ASSERT([download->wrapper() isKindOfClass:[_WKDownload class]]);
> -    [static_cast<_WKDownload *>(download->wrapper())
setOriginatingWebView:m_webView];
>  }

It would be nice if we could remove this PageClient call completely and make
all platforms do this the same way.  It seems like that's all GTK is doing
here, and WPE is in progress.