[webkit-reviews] review granted: [Bug 174130] Move more code from ScrollingStateOverflowScrollingNodeIOS to ScrollingTreeScrollingNodeDelegate : [Attachment 320011] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 174130: Move more code from ScrollingStateOverflowScrollingNodeIOS to
ScrollingTreeScrollingNodeDelegate
https://bugs.webkit.org/show_bug.cgi?id=174130

Attachment 320011: Patch

https://bugs.webkit.org/attachment.cgi?id=320011&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 320011
  --> https://bugs.webkit.org/attachment.cgi?id=320011
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320011&action=review

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.h:63
> +    void commitStateBeforeChildren(const
WebCore::ScrollingStateScrollingNode& scrollingStateNode);
> +    void commitStateAfterChildren(const
WebCore::ScrollingStateScrollingNode& scrollingStateNode);

No need to name scrollingStateNode.

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.h:66
> +    void setScrollLayerPosition(const WebCore::FloatPoint& scrollPosition);

No need to name scrollPosition

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.h:73
>      bool m_updatingFromStateNode;

{ false }

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.mm:177
> +		   m_scrollViewDelegate =
adoptNS([[WKScrollingNodeScrollViewDelegate alloc]
initWithScrollingTreeNodeDelegate:this]);

I wonder if this class could also be the WKScrollingNodeScrollViewDelegate, but
that could be done later.