[webkit-reviews] review granted: [Bug 176334] [WSL] Rationalize how protocol inheritance deals with type parameters : [Attachment 320130] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 176334: [WSL] Rationalize how protocol inheritance deals with type
parameters
https://bugs.webkit.org/show_bug.cgi?id=176334

Attachment 320130: the patch

https://bugs.webkit.org/attachment.cgi?id=320130&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 320130
  --> https://bugs.webkit.org/attachment.cgi?id=320130
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320130&action=review

r=me

> Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93
> +	       let overload = this.program.resolveFuncOverload(signature.name,
signature.typeParameters, signature.parameterTypes);

Not really due to this patch but "typeParameters" and "parameterTypes" sound
too similar.  Can there be better names for these?