[webkit-reviews] review granted: [Bug 176448] [WPE][CMake] Add "dist" and "distcheck" targets : [Attachment 320017] Patch (v3)

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 176448: [WPE][CMake] Add "dist" and "distcheck" targets
https://bugs.webkit.org/show_bug.cgi?id=176448

Attachment 320017: Patch (v3)

https://bugs.webkit.org/attachment.cgi?id=320017&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 320017
  --> https://bugs.webkit.org/attachment.cgi?id=320017
Patch (v3)

View in context: https://bugs.webkit.org/attachment.cgi?id=320017&action=review

> Source/PlatformWPE.cmake:2
> +    find_package(Xz REQUIRED)

Do we really want to force everybody to have xz installed when only maintainers
make releases? I guess most of the people have it installed already, but still.

> Tools/wpe/manifest.txt.in:66
> +# TODO: No NEWS file for now.

Sorry I missed this in previous review, but in WebKit we don't use TODO, but
always FIXME

> Tools/wpe/manifest.txt.in:93
> +# TODO: We are not currently generating documentation for WPE.

Ditto.