[webkit-reviews] review granted: [Bug 176495] [EME] CDMClearKey: implement remaining methods of CDMPrivate derivative : [Attachment 320100] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 7 04:03:41 PDT 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 176495: [EME] CDMClearKey: implement remaining methods of CDMPrivate
derivative
https://bugs.webkit.org/show_bug.cgi?id=176495

Attachment 320100: Patch

https://bugs.webkit.org/attachment.cgi?id=320100&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 320100
  --> https://bugs.webkit.org/attachment.cgi?id=320100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320100&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:167
> +    // Server certificates are not supported.

This is a bit redundant, but it does not harm.

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:173
> +    // Sessions are supported.

This is a bit redundant, but it does not harm.


More information about the webkit-reviews mailing list