[webkit-reviews] review denied: [Bug 176437] Modernize BoxExtent into RectEdge : [Attachment 319981] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 176437: Modernize BoxExtent into RectEdge
https://bugs.webkit.org/show_bug.cgi?id=176437

Attachment 319981: Patch

https://bugs.webkit.org/attachment.cgi?id=319981&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 319981
  --> https://bugs.webkit.org/attachment.cgi?id=319981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319981&action=review

>> Source/WebCore/ChangeLog:8
>> +	    And give it its own header.
> 
> I would include a blurb in the ChangeLog here about why RectEdge is a better
name than BoxExtent (from IRC, I learned from Alex that this is to better align
with NSRectEdge/UIRectEdge).

But RectEdge is a single edge. UIEdgeInsets is the set of 4 edges for a box, so
I don't think RectEdge is a good name. Maybe RectEdges?