[webkit-reviews] review granted: [Bug 176249] NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed : [Attachment 320055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 6 13:43:32 PDT 2017


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176249: NetworkProcess Cache and Caches should be cleared when the last
related WebProcess Cache or CacheStorage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=176249

Attachment 320055: Patch

https://bugs.webkit.org/attachment.cgi?id=320055&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320055
  --> https://bugs.webkit.org/attachment.cgi?id=320055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320055&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.h:68
> +    HashMap<PAL::SessionID, HashMap<uint64_t, uint64_t>> m_cachesReferences;

m_cacheReferences?
Also, could you typedef the uint64_t's so we can read what is going on here?


More information about the webkit-reviews mailing list