[webkit-reviews] review granted: [Bug 176462] Support caching of Response with a ReadableStream body : [Attachment 320028] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176462: Support caching of Response with a ReadableStream body
https://bugs.webkit.org/show_bug.cgi?id=176462

Attachment 320028: Patch

https://bugs.webkit.org/attachment.cgi?id=320028&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320028
  --> https://bugs.webkit.org/attachment.cgi?id=320028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320028&action=review

> Source/WebCore/bindings/js/ReadableStream.cpp:105
> +enum class Method { Locked, Disturbed };
> +template<Method method>

I think this should be two separate functions, or one with a function as a
parameter.  Most of the function is what is different.	Making two functions
wouldn't duplicate much code.