[webkit-reviews] review granted: [Bug 176381] [Win] Compile errors in Document::updateTitleElement. : [Attachment 320034] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 6 10:26:21 PDT 2017
Alex Christensen <achristensen at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 176381: [Win] Compile errors in Document::updateTitleElement.
https://bugs.webkit.org/show_bug.cgi?id=176381
Attachment 320034: Patch
https://bugs.webkit.org/attachment.cgi?id=320034&action=review
--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320034
--> https://bugs.webkit.org/attachment.cgi?id=320034
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320034&action=review
> Source/WebCore/dom/Document.cpp:1567
> +static bool isSVGTitle(Element& element)
> +{
> + return is<SVGTitleElement>(element);
Can we not just use is<SVGTitleElement> where we use isSVGTitle instead of
making a wrapper? Same with isHTMLTitle
More information about the webkit-reviews
mailing list