[webkit-reviews] review requested: [Bug 176448] [WPE][CMake] Add "dist" and "distcheck" targets : [Attachment 320010] Tentative patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 6 05:04:38 PDT 2017
Adrian Perez <aperez at igalia.com> has asked for review:
Bug 176448: [WPE][CMake] Add "dist" and "distcheck" targets
https://bugs.webkit.org/show_bug.cgi?id=176448
Attachment 320010: Tentative patch
https://bugs.webkit.org/attachment.cgi?id=320010&action=review
--- Comment #1 from Adrian Perez <aperez at igalia.com> ---
Created attachment 320010
--> https://bugs.webkit.org/attachment.cgi?id=320010&action=review
Tentative patch
This reuses the make-dist.py script used by the GTK+ port, and adds
a new manifest to be used when assembling a WPE tarball, plus the needed
commands/targets.
I wonder whether it would be a good idea to factor out the common parts and use
the ${PORT}
variable in the commands in order to avoid repeating the code for WPE... WDYT?
More information about the webkit-reviews
mailing list