[webkit-reviews] review granted: [Bug 176431] [Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined. : [Attachment 319954] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 176431: [Win] WebCore failed to build, InbandTextTrackPrivateAVF: base
class undefined.
https://bugs.webkit.org/show_bug.cgi?id=176431

Attachment 319954: Patch

https://bugs.webkit.org/attachment.cgi?id=319954&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319954
  --> https://bugs.webkit.org/attachment.cgi?id=319954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319954&action=review

> Source/WebCore/config.h:32
> +#if PLATFORM(WIN) && !USE(WINGDI)

!USE(WINGDI) is unnecessary.  The WinCE port of yesteryear used that.

> Source/WebCore/config.h:112
> +// FIXME: Move this to JavaScriptCore/wtf/Platform.h, which is where we
define USE_AVFOUNDATION on the Mac.

We should just define USE_AVFOUNDATION in WebCore on Mac.  We've done it all
wrong if JavaScriptCore depends on AVFoundation.