[webkit-reviews] review granted: [Bug 176429] isNotCellSpeculation is wrong w.r.t SpecCellCheck : [Attachment 319956] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 5 16:50:58 PDT 2017
Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 176429: isNotCellSpeculation is wrong w.r.t SpecCellCheck
https://bugs.webkit.org/show_bug.cgi?id=176429
Attachment 319956: patch
https://bugs.webkit.org/attachment.cgi?id=319956&action=review
--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 319956
--> https://bugs.webkit.org/attachment.cgi?id=319956
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319956&action=review
r=me
> Source/JavaScriptCore/ChangeLog:9
> + the SpecEmpty in the set for t. It should return false when the
SpecEmpty is present,
nit - Is "the" before the second SpecEmpty unnecessary?
More information about the webkit-reviews
mailing list