[webkit-reviews] review granted: [Bug 175857] Relax keychain access to permit users to permanently allow client certificates : [Attachment 319948] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 175857: Relax keychain access to permit users to permanently allow client
certificates
https://bugs.webkit.org/show_bug.cgi?id=175857

Attachment 319948: Patch

https://bugs.webkit.org/attachment.cgi?id=319948&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319948
  --> https://bugs.webkit.org/attachment.cgi?id=319948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319948&action=review

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:168
> -(allow file-read-data file-read-metadata file-write-create file-write-data
> +(allow file-read-data file-read-metadata file-write*

Wouldn't it be better to just expand the list rather than just giving it a
wildcard?