[webkit-reviews] review granted: [Bug 176424] [Win] Enable DatatransferItems in DRT. : [Attachment 319938] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 5 15:40:03 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 176424: [Win] Enable DatatransferItems in DRT.
https://bugs.webkit.org/show_bug.cgi?id=176424

Attachment 319938: Patch

https://bugs.webkit.org/attachment.cgi?id=319938&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 319938
  --> https://bugs.webkit.org/attachment.cgi?id=319938
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319938&action=review

r=me, as long as we don't have shipping software that depends on
IWebPreferencesPrivate5 having only two API points.

> Source/WebKitLegacy/win/WebPreferences.h:263
> +    virtual HRESULT STDMETHODCALLTYPE setDataTransferItemsEnabled(BOOL);

Can you confirm that IWebPreferencesPrivate5 is not currently shipping to
users? If it is, we will need to make IWPP6. :-(


More information about the webkit-reviews mailing list