[webkit-reviews] review denied: [Bug 175232] Resource Load Statistics: Immediately deny third-party cookie creation for prevalent resources without interaction (rather than temporarily accepting the cookie) : [Attachment 319920] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 175232: Resource Load Statistics: Immediately deny third-party cookie
creation for prevalent resources without interaction (rather than temporarily
accepting the cookie)
https://bugs.webkit.org/show_bug.cgi?id=175232

Attachment 319920: Patch

https://bugs.webkit.org/attachment.cgi?id=319920&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319920
  --> https://bugs.webkit.org/attachment.cgi?id=319920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319920&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:82
> +    RetainPtr<NSURLSession> m_sessionWithoutCredentialOrCookieStorage;
> +    RetainPtr<WKNetworkSessionDelegate>
m_sessionWithoutCredentialOrCookieStorageDelegate;

To be more clear, I think we should not add a new NSURLSession per
NetworkSession just for this.  I think we should make the
m_sessionWithoutCredentialStorage not store cookies either instead.  I think we
should do that in a separate patch, and I think this patch depends on that
patch.