[webkit-reviews] review denied: [Bug 172914] Add "offset in parent" to ScrollingCoordinator::ScrollingGeometry : [Attachment 312004] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 5 08:46:29 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 172914: Add "offset in parent" to ScrollingCoordinator::ScrollingGeometry
https://bugs.webkit.org/show_bug.cgi?id=172914

Attachment 312004: Patch

https://bugs.webkit.org/attachment.cgi?id=312004&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312004
  --> https://bugs.webkit.org/attachment.cgi?id=312004
Patch

I think we should store a rect for each node (to handle borders/padding
correctly), and I guess each rect could be relative to its parent node?


More information about the webkit-reviews mailing list