[webkit-reviews] review granted: [Bug 176332] EWS should report when a step succeeds : [Attachment 319860] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 4 16:26:49 PDT 2017
Sam Weinig <sam at webkit.org> has granted Aakash Jain <aakash_jain at apple.com>'s
request for review:
Bug 176332: EWS should report when a step succeeds
https://bugs.webkit.org/show_bug.cgi?id=176332
Attachment 319860: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=319860&action=review
--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 319860
--> https://bugs.webkit.org/attachment.cgi?id=319860
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319860&action=review
> Tools/ChangeLog:8
> + Reviewed by NOBODY (OOPS!).
> +
> + * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Nice. The ChangeLog could use a bit more of a 'why' description. You have a
pretty good one in the first comment of the bug which should take you most of
the way there!
More information about the webkit-reviews
mailing list