[webkit-reviews] review granted: [Bug 176330] [GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX) : [Attachment 319850] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 4 11:55:45 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 176330: [GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
https://bugs.webkit.org/show_bug.cgi?id=176330

Attachment 319850: Patch

https://bugs.webkit.org/attachment.cgi?id=319850&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 319850
  --> https://bugs.webkit.org/attachment.cgi?id=319850
Patch

/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/
NetscapePluginModuleUnix.cpp: In member function 'void
WebKit::NetscapePluginModule::determineQuirks()':
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/
NetscapePluginModuleUnix.cpp:187:32: error: 'IgnoreRightClickInWindowlessMode'
is not a member of 'WebKit::PluginQuirks'
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/
NetscapePluginModuleUnix.cpp:189:32: error:
'DoNotCancelSrcStreamInWindowedMode' is not a member of 'WebKit::PluginQuirks'


More information about the webkit-reviews mailing list