[webkit-reviews] review granted: [Bug 175329] REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure : [Attachment 319811] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 175329: REGRESSION (r220052): [Sierra] API test
VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175329

Attachment 319811: Patch

https://bugs.webkit.org/attachment.cgi?id=319811&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 319811
  --> https://bugs.webkit.org/attachment.cgi?id=319811
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319811&action=review

> Tools/ChangeLog:9
> +	   video controls to appear. With changes to how loading occurrs, it
can now

Nit - occurrs => occurs

> Tools/ChangeLog:13
> +	   changing the tests to wait one more run loop should get rid of the
flakiness.

In the longer term, I think it makes more sense for some of these tests to
expect media controls to show up eventually, instead of expecting them after a
"playing" message sent after a 0-delay timer in the web process. As you noted,
there isn't a guarantee of how many run loop cycles it would take for the web
process to be in a state where it wants to show media controls, nor should
there be, since touch bar presence for media elements isn't web/API exposed.