[webkit-reviews] review granted: [Bug 175236] Update font selection algorithm to match latest CSS spec : [Attachment 317701] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 175236: Update font selection algorithm to match latest CSS spec
https://bugs.webkit.org/show_bug.cgi?id=175236

Attachment 317701: Patch

https://bugs.webkit.org/attachment.cgi?id=317701&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 317701
  --> https://bugs.webkit.org/attachment.cgi?id=317701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317701&action=review

> Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:220
> +static inline FontSelectionValue lowerWeightSearchThreshold()

All these functions that return FontSelectionValue could instead return const
FontSelectionValue&. Unclear to me how OK it is that they copy every time they
are called.

> LayoutTests/ChangeLog:9
> +	   * fast/text/variations/font-selection-font-weight-expected.html:
Added.
> +	   * fast/text/variations/font-selection-font-weight.html: Added.

Note that reference tests only compare the top 800x600; is this test fitting or
spilling off the bottom?