[webkit-reviews] review granted: [Bug 176324] Use StringView in DOMFileSystem::evaluatePath() : [Attachment 319833] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 3 21:45:31 PDT 2017
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 176324: Use StringView in DOMFileSystem::evaluatePath()
https://bugs.webkit.org/show_bug.cgi?id=176324
Attachment 319833: Patch
https://bugs.webkit.org/attachment.cgi?id=319833&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 319833
--> https://bugs.webkit.org/attachment.cgi?id=319833
Patch
Seems like a good first step. But I think that virtualPathSegments and
relativePathSegments can also be StringView, for example. And we can write a
pathByAppendingComponents that takes StringView too.
More information about the webkit-reviews
mailing list