[webkit-reviews] review granted: [Bug 176301] [WTF] Add C++03 allocator interface for GCC < 6 : [Attachment 319773] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 176301: [WTF] Add C++03 allocator interface for GCC < 6
https://bugs.webkit.org/show_bug.cgi?id=176301

Attachment 319773: Patch

https://bugs.webkit.org/attachment.cgi?id=319773&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 319773
  --> https://bugs.webkit.org/attachment.cgi?id=319773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319773&action=review

> Source/WTF/wtf/FastMalloc.h:129
> +    // This allocator also supports pre-C++11 STL allocator interface. This
is a workaround for GCC < 6, which std::list
> +    // does not support C++11 allocator.

Can we put an #if around this that enables it only for that older GCC? That way
we will remember to delete the code later once we drop support for that older
compiler, and we will also know it’s safe to do so since we won’t accidentally
depend on it, on other platforms.