[webkit-reviews] review granted: [Bug 176274] Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked : [Attachment 319709] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176274: Add WKUIDelegatePrivate equivalent of WKPageUIClient's
unavailablePluginButtonClicked
https://bugs.webkit.org/show_bug.cgi?id=176274

Attachment 319709: Patch

https://bugs.webkit.org/attachment.cgi?id=319709&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 319709
  --> https://bugs.webkit.org/attachment.cgi?id=319709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319709&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:120
> +#if !TARGET_OS_IOS

I think this should be written in the affirmative, #if TARGET_OS_MAC (whatever
the right name for that is), because the default for any new target should be
no plugins.

Also, in the past I thought the official name was "plug-in", not "plugin", and
therefore the "I" would be capitalized in public identifiers like
_plugInsEnabled.