[webkit-reviews] review denied: [Bug 171230] [GTK] Libgcrypt warning: missing initialization - please fix the application : [Attachment 319718] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171230: [GTK] Libgcrypt warning: missing initialization - please fix the
application
https://bugs.webkit.org/show_bug.cgi?id=171230

Attachment 319718: Patch

https://bugs.webkit.org/attachment.cgi?id=319718&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 319718
  --> https://bugs.webkit.org/attachment.cgi?id=319718
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319718&action=review

Thanks!

> Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:56
> +#if USE(GCRYPT)
> +    // Call gcry_check_version() before any other libgcrypt call, ignoring
the
> +    // returned version string.
> +    gcry_check_version(nullptr);
> +
> +    // Pre-allocate 16kB of secure memory and finish the initialization.
> +    gcry_control(GCRYCTL_INIT_SECMEM, 16384, nullptr);
> +    gcry_control(GCRYCTL_INITIALIZATION_FINISHED, nullptr);
> +#endif

We should move this down to PAL so we don't have to duplicate it in multiple
places. Probably time to add a
Source/WebCore/PAL/pal/crypto/gcrypt/Utilities.cpp.