[webkit-reviews] review requested: [Bug 139438] [CMake] Enable pre-compiled headers (PCH) (cotire) : [Attachment 319715] Simple approach, now with include paths and defines passed when building PCHs

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 139438: [CMake] Enable pre-compiled headers (PCH) (cotire)
https://bugs.webkit.org/show_bug.cgi?id=139438

Attachment 319715: Simple approach, now with include paths and defines passed
when building PCHs

https://bugs.webkit.org/attachment.cgi?id=319715&action=review




--- Comment #20 from Adrian Perez <aperez at igalia.com> ---
Created attachment 319715

  --> https://bugs.webkit.org/attachment.cgi?id=319715&action=review

Simple approach, now with include paths and defines passed when building PCHs


Here goes a new version of the simpler approach, which is not so
simple anymore, but it does not properly add the compiler defines
and include paths when compiling the prefix headers. In order to
get the lists of flags an extra parameter is passed to the macro,
which is the name of the target from which to pick the compiler
flags. The flags are written to a response file because that way
it is done as the last step after all the compilation setup has
been completed -- otherwise not all the flags get picked, in case
the WEBKIT_ADD_PRECOMPILED_HEADER is called *before* additional
options are set, which can happen in port-specific CMake snippets.

This version properly builds the PCHs, and I am waiting for the
builds to finish to be able to provide timings and validate that
WebKit is built correctly.

:-D