[webkit-reviews] review requested: [Bug 139438] [CMake] Enable pre-compiled headers (PCH) (cotire) : [Attachment 319687] Alternative take, reusing existing macro

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 139438: [CMake] Enable pre-compiled headers (PCH) (cotire)
https://bugs.webkit.org/show_bug.cgi?id=139438

Attachment 319687: Alternative take, reusing existing macro

https://bugs.webkit.org/attachment.cgi?id=319687&action=review




--- Comment #16 from Adrian Perez <aperez at igalia.com> ---
Created attachment 319687

  --> https://bugs.webkit.org/attachment.cgi?id=319687&action=review

Alternative take, reusing existing macro

It turns out, the WebKit CMake files already had support
for doing precompiled headers with MSVC, so the best solution
in the end seemed to be to just hook there the missing CMake
spell to have it working for GCC and Clang. I reached this
solution after a long night trying to understand Cotire and
the suggestion by Konstantin, cmake-precompiled-header. Right
now I left my laptop doing a build, so no timings yet until
I get some hours of sleep -- hopefully the build will complete.

FWIW, personally I prefer this much simpler approach :-D

P.S: The patch will not pass the style checker, it is quite WIP
but I wanted to share it anyway so you can all give feedback.